[OE-core] [PATCH 10/22] tune/arch-powerpc: Use fpu-soft to set PPCPKGSFX_FPU

Richard Purdie richard.purdie at linuxfoundation.org
Mon Aug 1 13:03:19 UTC 2011


On Mon, 2011-08-01 at 00:36 -0700, Saul Wold wrote:
> From: Kumar Gala <galak at kernel.crashing.org>
> 
> Its more likely that we explicitly set soft-floating point support for a
> given target than hard.  So use 'fpu-soft' in TUNE_FEATURES rather than
> 'fpu-hard' to determine setting 'nf' (no-float) in PPCPKGSFX_FPU.
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
>  meta/conf/machine/include/powerpc/arch-powerpc.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
> index 8cc76ab..013755d 100644
> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
> @@ -18,7 +18,7 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>  
>  ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>  
> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
> +PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "-nf", "", d)}"
>  
>  TUNE_PKGARCH ?= "${TUNE_ARCH}${PPCPKGSFX_FPU}"

Whilst the change itself may or may not be ok, it would need to change
the various boards that are already setting or not setting fpu-hard as a
feature so as it stands this change is incomplete.

Cheers,

Richard







More information about the Openembedded-core mailing list