[OE-core] [PATCH 3/5] self-hosted: Add ext2 utilites and perl-pod for building

Paul Menzel paulepanter at users.sourceforge.net
Sun Dec 11 07:05:19 UTC 2011


Dear Saul,


Am Samstag, den 10.12.2011, 14:01 -0800 schrieb Saul Wold:
> Add self-hosted-host-tools for non-build related tools
> 
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
>  meta/recipes-core/tasks/task-self-hosted.bb |   54 +++++++++++++++-----------
>  1 files changed, 31 insertions(+), 23 deletions(-)
> 
> diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
> index b3a68b4..b9bdd21 100644
> --- a/meta/recipes-core/tasks/task-self-hosted.bb
> +++ b/meta/recipes-core/tasks/task-self-hosted.bb
> @@ -3,7 +3,7 @@
>  #
>  
>  DESCRIPTION = "Create Basic Image Tasks"
> -PR = "r1"
> +PR = "r2"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> @@ -14,6 +14,7 @@ PACKAGES = "\
>      task-self-hosted-sdk \
>      task-self-hosted-extended \
>      task-self-hosted-graphics \
> +    task-self-hosted-host-tools \
>      "
>  
>  ALLOW_EMPTY = "1"
> @@ -23,13 +24,26 @@ RDEPENDS_task-self-hosted = "\
>      task-self-hosted-sdk \
>      task-self-hosted-extended \
>      task-self-hosted-graphics \
> +    task-self-hosted-host-tools \
> +    "
> +
> +RDEPENDS_task-self-hosted-host-tools = "\
> +    e2fsprogs \
> +    dhcp-client \
> +    genext2fs \
> +    hdparm \
> +    iptables \
> +    kernel-module-tun \
> +    kernel-module-iptable-raw \
> +    kernel-module-iptable-nat \
> +    kernel-module-iptable-mangle \
> +    kernel-module-iptable-filter \
> +    mc \
> +    screen \
>      "

[…]

I find this patch quite hard to review, since it reorders the
variables(?). Is there a trick to review this or are two separate
patches better.

Could you also please check your pull request script to send

    <openembedded-core at lists.openembedded.org>

instead of

    <openembedded-core at openembedded.org>

and therefore answering to all messages are sent twice to the list.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20111211/f5157b5e/attachment-0002.sig>


More information about the Openembedded-core mailing list