[OE-core] [PATCH 3/5] self-hosted: Add ext2 utilites and perl-pod for building

[Saul Wold]

On 12/10/2011 11:05 PM, Paul Menzel wrote:
> Dear Saul,
>
>
> Am Samstag, den 10.12.2011, 14:01 -0800 schrieb Saul Wold:
>> Add self-hosted-host-tools for non-build related tools
>>
>> Signed-off-by: Saul Wold<sgw at linux.intel.com>
>> ---
>>   meta/recipes-core/tasks/task-self-hosted.bb |   54 +++++++++++++++-----------
>>   1 files changed, 31 insertions(+), 23 deletions(-)
>>
>> diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
>> index b3a68b4..b9bdd21 100644
>> --- a/meta/recipes-core/tasks/task-self-hosted.bb
>> +++ b/meta/recipes-core/tasks/task-self-hosted.bb
>> @@ -3,7 +3,7 @@
>>   #
>>
>>   DESCRIPTION = "Create Basic Image Tasks"
>> -PR = "r1"
>> +PR = "r2"
>>   LICENSE = "MIT"
>>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> @@ -14,6 +14,7 @@ PACKAGES = "\
>>       task-self-hosted-sdk \
>>       task-self-hosted-extended \
>>       task-self-hosted-graphics \
>> +    task-self-hosted-host-tools \
>>       "
>>
>>   ALLOW_EMPTY = "1"
>> @@ -23,13 +24,26 @@ RDEPENDS_task-self-hosted = "\
>>       task-self-hosted-sdk \
>>       task-self-hosted-extended \
>>       task-self-hosted-graphics \
>> +    task-self-hosted-host-tools \
>> +    "
>> +
>> +RDEPENDS_task-self-hosted-host-tools = "\
>> +    e2fsprogs \
>> +    dhcp-client \
>> +    genext2fs \
>> +    hdparm \
>> +    iptables \
>> +    kernel-module-tun \
>> +    kernel-module-iptable-raw \
>> +    kernel-module-iptable-nat \
>> +    kernel-module-iptable-mangle \
>> +    kernel-module-iptable-filter \
>> +    mc \
>> +    screen \
>>       "
>
> […]
>
> I find this patch quite hard to review, since it reorders the
> variables(?). Is there a trick to review this or are two separate
> patches better.
>
No trick, just moved a couple of items that where in the wrong place 
from one task to the host-tools task.

> Could you also please check your pull request script to send
>
>      <openembedded-core at lists.openembedded.org>
>
> instead of
>
>      <openembedded-core at openembedded.org>
>
> and therefore answering to all messages are sent twice to the list.
>
Sure, not sure why that would be happening.

Sau!

>
> Thanks,
>
> Paul
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core