[OE-core] [PATCH 03/50] libiconv: Add recipes for 1.13.1

Richard Purdie richard.purdie at linuxfoundation.org
Wed Jul 20 14:14:08 UTC 2011


On Wed, 2011-07-20 at 01:27 -0700, Saul Wold wrote:
> From: Khem Raj <raj.khem at gmail.com>
> 
> Import 1.13.1 recipes from meta-oe
> share common code through libiconv.inc
> 
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  .../libiconv/libiconv-1.13.1/autoconf.patch        |16018 ++++++++++++++++++++
>  meta/recipes-support/libiconv/libiconv.inc         |   18 +
>  meta/recipes-support/libiconv/libiconv_1.11.1.bb   |   24 +-
>  meta/recipes-support/libiconv/libiconv_1.13.1.bb   |   20 +
>  4 files changed, 16061 insertions(+), 19 deletions(-)
>  create mode 100644 meta/recipes-support/libiconv/libiconv-1.13.1/autoconf.patch
>  create mode 100644 meta/recipes-support/libiconv/libiconv.inc
>  create mode 100644 meta/recipes-support/libiconv/libiconv_1.13.1.bb

I've given feedback elsewhere about this. Please can we combine the best
bits of the recipes rather than overwrite one with the other. I think
removing the libtool.m4 file directly rather than patching is a better
approach as per the current recipe for example.

I also suspect the .inc file wasn't used specifically due to the
gplv2/v3 contamination issue. I'm fine with having a .inc file but the
gplv2 recipe probably shouldn't use it.

Cheers,

Richard





More information about the Openembedded-core mailing list