[OE-core] [PATCH 03/50] libiconv: Add recipes for 1.13.1

[Khem Raj]

On 07/20/2011 07:14 AM, Richard Purdie wrote:
> On Wed, 2011-07-20 at 01:27 -0700, Saul Wold wrote:
>> From: Khem Raj<raj.khem at gmail.com>
>>
>> Import 1.13.1 recipes from meta-oe
>> share common code through libiconv.inc
>>
>> Signed-off-by: Khem Raj<raj.khem at gmail.com>
>> ---
>>   .../libiconv/libiconv-1.13.1/autoconf.patch        |16018 ++++++++++++++++++++
>>   meta/recipes-support/libiconv/libiconv.inc         |   18 +
>>   meta/recipes-support/libiconv/libiconv_1.11.1.bb   |   24 +-
>>   meta/recipes-support/libiconv/libiconv_1.13.1.bb   |   20 +
>>   4 files changed, 16061 insertions(+), 19 deletions(-)
>>   create mode 100644 meta/recipes-support/libiconv/libiconv-1.13.1/autoconf.patch
>>   create mode 100644 meta/recipes-support/libiconv/libiconv.inc
>>   create mode 100644 meta/recipes-support/libiconv/libiconv_1.13.1.bb
>
> I've given feedback elsewhere about this. Please can we combine the best
> bits of the recipes rather than overwrite one with the other. I think
> removing the libtool.m4 file directly rather than patching is a better
> approach as per the current recipe for example.
>

yes I will test it out and resubmit

> I also suspect the .inc file wasn't used specifically due to the
> gplv2/v3 contamination issue.

ok makes sense. i will rework it to be separate

  I'm fine with having a .inc file but the
> gplv2 recipe probably shouldn't use it.
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core