[OE-core] [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Martin Jansa]

On Wed, Feb 22, 2012 at 10:13:09PM +0000, git at git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> 
> Author: Joshua Lock <josh at linux.intel.com>
> Date:   Tue Feb 21 17:46:44 2012 -0800
> 
> netbase: remove redundant assignments
> 
> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> takes care of setting this value for us based on the interfaces for those
> machines being an OVERRIDE.

do_install () {
...
        # Disable network manager on machines that commonly do NFS booting
        case "${MACHINE}" in
                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )

This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
TARGET_ARCH package after every MACHINE switch.

Cheers,

> 
> Signed-off-by: Joshua Lock <josh at linux.intel.com>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> ---
> 
>  meta/recipes-core/netbase/netbase_4.47.bb |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-core/netbase/netbase_4.47.bb b/meta/recipes-core/netbase/netbase_4.47.bb
> index ddfa8ad..3aa4915 100644
> --- a/meta/recipes-core/netbase/netbase_4.47.bb
> +++ b/meta/recipes-core/netbase/netbase_4.47.bb
> @@ -47,7 +47,3 @@ do_install () {
>  }
>  
>  CONFFILES_${PN} = "${sysconfdir}/hosts ${sysconfdir}/network/interfaces"
> -
> -PACKAGE_ARCH_qemuarm = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86 = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86-64 = "${MACHINE_ARCH}"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120227/f9514b6a/attachment-0002.sig>