[OE-core] [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Koen Kooi]

Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:

> On Wed, Feb 22, 2012 at 10:13:09PM +0000, git at git.openembedded.org wrote:
>> Module: openembedded-core.git
>> Branch: master
>> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
>> 
>> Author: Joshua Lock <josh at linux.intel.com>
>> Date:   Tue Feb 21 17:46:44 2012 -0800
>> 
>> netbase: remove redundant assignments
>> 
>> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
>> takes care of setting this value for us based on the interfaces for those
>> machines being an OVERRIDE.
> 
> do_install () {
> ...
>        # Disable network manager on machines that commonly do NFS booting
>        case "${MACHINE}" in
>                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> 
> This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> TARGET_ARCH package after every MACHINE switch.

That whole bit needs to go into the specific nfs image recipe, not into the recipe. Unless we decide nfs is the one and only way to boot qemu machines.

regards,

Koen