[OE-core] [CONSOLIDATED PULL 16/19] tunearch/arm: Differentiate between thumb code generation and thumb capability

Phil Blundell philb at gnu.org
Tue Jan 31 10:48:37 UTC 2012


On Mon, 2012-01-30 at 20:13 -0800, Saul Wold wrote:
> We have diverged a bit from oe.dev where thumb in OVERRIDES meant
> the code was being compiled in thumb mode. With tunearch this got
> a different meaning where it meant that if a core is capable of
> generating thumb code them we will have this in overrides. With this
> patch I am trying to address the problem where 'thumbmode' in TUNE_FEATURES
> means that code will be compiled in thumb mode by default and
> 'thumb' is to denote that core is capable of thumb instruction set.

So this patch is changing the meaning of the "thumb" override in
oe-core, right?  Is that really a good idea?

Also, I'm not quite sure I understand what the "thumb" tuning would be
useful for when this patch is applied.  You seem to have removed most of
the code which checks for "thumb" in TUNE_FEATURES which seems to leave
it not doing anything very much.

Can you clarify what exactly is the problem that this patch is solving,
what the old and new semantics of the overrides and tune flags are, and
why it's an improvement?

p.






More information about the Openembedded-core mailing list