[OE-core] [PATCH 1/1] oprofile: Change /root to /home/root

Phil Blundell philb at gnu.org
Mon Jul 2 20:06:42 UTC 2012


On Mon, 2012-07-02 at 14:25 -0500, Mark Hatle wrote:
> +diff -ur oprofile-0.9.7.orig/utils/opcontrol oprofile-0.9.7/utils/opcontrol
> +--- oprofile-0.9.7.orig/utils/opcontrol	2011-07-20 14:36:48.000000000 -0500
> ++++ oprofile-0.9.7/utils/opcontrol	2012-07-02 13:55:06.232872688 -0500
> +@@ -384,7 +384,7 @@
> + 	OPROFILED="$OPDIR/oprofiled"
> + 
> + 	# location for daemon setup information
> +-	SETUP_DIR="/root/.oprofile"
> ++	SETUP_DIR="/home/root/.oprofile"
> + 	SETUP_FILE="$SETUP_DIR/daemonrc"
> + 	SEC_SETUP_FILE="$SETUP_DIR/daemonrc_new"
> + 

Why is it putting "daemon setup information" in /root in the first
place?  Surely that should go in /etc or some such place.

Also, the choice of where root's home directory goes is a distro
decision and, in the general case, it is not correct to say that "OE
uses /home/root".  Changing the hardcoded value from one thing to
another is probably not that much of an improvement overall. 

p.






More information about the Openembedded-core mailing list