[OE-core] [PATCH 1/1] oprofile: Change /root to /home/root

[Mark Hatle]

On 7/2/12 3:06 PM, Phil Blundell wrote:
> On Mon, 2012-07-02 at 14:25 -0500, Mark Hatle wrote:
>> +diff -ur oprofile-0.9.7.orig/utils/opcontrol oprofile-0.9.7/utils/opcontrol
>> +--- oprofile-0.9.7.orig/utils/opcontrol	2011-07-20 14:36:48.000000000 -0500
>> ++++ oprofile-0.9.7/utils/opcontrol	2012-07-02 13:55:06.232872688 -0500
>> +@@ -384,7 +384,7 @@
>> + 	OPROFILED="$OPDIR/oprofiled"
>> +
>> + 	# location for daemon setup information
>> +-	SETUP_DIR="/root/.oprofile"
>> ++	SETUP_DIR="/home/root/.oprofile"
>> + 	SETUP_FILE="$SETUP_DIR/daemonrc"
>> + 	SEC_SETUP_FILE="$SETUP_DIR/daemonrc_new"
>> +
>
> Why is it putting "daemon setup information" in /root in the first
> place?  Surely that should go in /etc or some such place.
>
> Also, the choice of where root's home directory goes is a distro
> decision and, in the general case, it is not correct to say that "OE
> uses /home/root".  Changing the hardcoded value from one thing to
> another is probably not that much of an improvement overall.

systemd (meta-oe), base-passwd, base-files (profile settings), xserver-
nodm-init-2.0/xserver-nodm -- they all have patches that change hard coded /root 
to /home/root.

I don't honestly care which we used, but /home/root has been used as -the- root 
directory on OE since as far back as 2004 from what I can tell.

As for the files, these are files used by the system to setup and store the 
data.  oprofile does this to the root home directory.  I don't know or 
understand why, other then I have a bug in my pile that says oprofile is 
currently broken, as there is no /root directory.

--Mark

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>