[OE-core] isn't the check for a matching "meta" branch a bit too forgiving?
Robert P. J. Day
rpjday at crashcourse.ca
Sun Jul 15 01:01:35 UTC 2012
in kernel-yocto.bbclass, in do_kernel_checkout(), isn't this check:
git branch -a | grep -q ${KMETA} <-- this check
if [ $? -ne 0 ]; then
echo "ERROR. The branch '${KMETA}' is required and was not"
echo "found. Ensure that the SRC_URI points to a valid linux-yocto"
... snip ...
for now, as long as KMETA always equals "meta", it's fine, but won't
that "grep" also erroneously match longer strings of which ${KMETA} is
simply a substring?
at the very least, shouldn't that be "grep -qw ${KMETA}"?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
More information about the Openembedded-core
mailing list