[OE-core] [PATCH 2/3] busybox: Add setsid and cttyhack for tiny DISTRO_FEATURE

[Darren Hart]

On 06/14/2012 02:41 AM, Phil Blundell wrote:
> On Wed, 2012-06-13 at 22:19 -0700, Darren Hart wrote:
>> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
>> index 5b83d32..d07ba7e 100644
>> --- a/meta/recipes-core/busybox/busybox.inc
>> +++ b/meta/recipes-core/busybox/busybox.inc
>> @@ -57,6 +57,8 @@ def features_to_busybox_settings(d):
>>  	busybox_cfg('nls',  distro_features, 'CONFIG_LOCALE_SUPPORT', cnf, rem)
>>  	busybox_cfg('ipv4', distro_features, 'CONFIG_FEATURE_IFUPDOWN_IPV4', cnf, rem)
>>  	busybox_cfg('ipv6', distro_features, 'CONFIG_FEATURE_IFUPDOWN_IPV6', cnf, rem)
>> +	busybox_cfg('tiny', distro_features, 'CONFIG_SETSID', cnf, rem)
>> +	busybox_cfg('tiny', distro_features, 'CONFIG_CTTYHACK', cnf, rem)
>>  	return "\n".join(cnf), "\n".join(rem)
>>  
>>  # X, Y = ${@features_to_uclibc_settings(d)}
> 
> What exactly is the mission of the "tiny" DISTRO_FEATURE?  It doesn't
> seem very wholesome for it to be enabling a random grab-bag of bits in
> busybox (or anywhere else).

The idea is to avoid having to bbappend busybox and other recipes
basically. I can see how "tiny" is different than "ipv4" as it isn't
explicit it what it enables, making it a "grab-bag" as you put it.

I could come up with a term that describes systems without complex init
systems that need to be able to setup their own shells easily.

Another approach would be to just consider these two features and decide
if they shouldn't just be part of the oe-core busybox defconfig anyway.
I don't see why setsid shouldn't be. I can see arguments against
cttyhack (as it is a hack), but I wouldn't think either should be a huge
deal to just include. I thought the DISTRO_FEATURE was a reasonable
compromise between that and having to maintain a bbappend outside of
oe-core.

> 
> If poky-tiny wants those features enabled then it can, and should, ship
> its own configuration for busybox which turns them on.  I think that
> would be better than further proliferation of switches in oe-core.
> 

How would you feel about just including these two features in the
defconfig then?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel