[OE-core] [PATCH 2/3] busybox: Add setsid and cttyhack for tiny DISTRO_FEATURE

[Phil Blundell]

On Thu, 2012-06-14 at 06:55 -0700, Darren Hart wrote:
> Another approach would be to just consider these two features and decide
> if they shouldn't just be part of the oe-core busybox defconfig anyway.
> I don't see why setsid shouldn't be. I can see arguments against
> cttyhack (as it is a hack), but I wouldn't think either should be a huge
> deal to just include. I thought the DISTRO_FEATURE was a reasonable
> compromise between that and having to maintain a bbappend outside of
> oe-core.

Well, you don't need to maintain a .bbappend as such: you can just
provide your own, completely custom config file for busybox.  That's
what micro does, what shr does (I think), and what I would suggest that
most DISTROs with non-trivial configuration requirements should probably
do.

I think most folks do actually use a .bbappend to fiddle FILESPATH in
order to get the configuration file picked up, but I'm fairly sure you
could do this with a bit of suitable magic in your distro config file
and avoid the .bbappend altogether.

> How would you feel about just including these two features in the
> defconfig then?

Not massively enthusiastic, simply because the logical conclusion of
that approach is that we end up with basically everything in busybox
turned on.  If we're going to go along that path then I think I would
prefer us to be up-front about it and just make the oe-core default
configuration for busybox be a "maximum features enabled" one. 

p.