[OE-core] [RFC v2][PATCH 1/3] buildhistory: record all builds

Martin Jansa martin.jansa at gmail.com
Thu Mar 22 14:33:18 UTC 2012


On Thu, Mar 22, 2012 at 02:25:38PM +0000, Paul Eggleton wrote:
> On Thursday 22 March 2012 11:35:30 Koen Kooi wrote:
> > After a few more days of usage I'm going to create a follow-up patch that
> > will do:
> > 
> > 1) reinstate the global git status --porcelain and make a single, empty
> > commit if nothing changed instead of N empty commits. 2) either parse the
> > output of git status or re-run it to see which top level entries need to
> > get committed and only run 'git add ; git commit' on those.
> >
> > That will keep tracking all builds, but will be less noisy. But it will be
> > slightly slower when the OS doesn't cache the git status, but I decided
> > that I can personally live with that.
> > 
> > So what do you think about that? 
> 
> Well, avoiding >1 empty commits sounds good. I'm happy to go with your 
> assessment as you're more likely to be observing actual performance than me 
> (I'm not really monitoring the performance of buildhistory on our autobuilder, 
> only the output).

Koen please make it to reuse output..

git status --porcelain takes ages here and even more on my 2nd buildhost
so even with 2nd run just after 1st probably faster I hope it will be
worth reparsing.

OE @ ~/shr-core/tmp-eglibc/buildhistory $ du -sh .
520M    .
and after git gc..
OE @ ~/shr-core/tmp-eglibc/buildhistory $ du -sh .
378M    .

> FYI I didn't comment on the splitting into separate commits patch earlier 
> because it doesn't really bother me either way. I do think people will find it 
> easier to use the buildhistory-diff tool rather than looking at the git log 
> directly (or the web-based equivalent when I finish that.); but I'm happy to 
> continue supporting those that prefer to read the log.

same here

> > If you like the idea, would you like it as follow up or as a respin of the
> > series?

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120322/0e64d0ac/attachment-0002.sig>


More information about the Openembedded-core mailing list