[OE-core] [RFC v2][PATCH 1/3] buildhistory: record all builds

[Koen Kooi]

Op 22 mrt. 2012, om 15:25 heeft Paul Eggleton het volgende geschreven:

> On Thursday 22 March 2012 11:35:30 Koen Kooi wrote:
>> After a few more days of usage I'm going to create a follow-up patch that
>> will do:
>> 
>> 1) reinstate the global git status --porcelain and make a single, empty
>> commit if nothing changed instead of N empty commits. 2) either parse the
>> output of git status or re-run it to see which top level entries need to
>> get committed and only run 'git add ; git commit' on those.
>> 
>> That will keep tracking all builds, but will be less noisy. But it will be
>> slightly slower when the OS doesn't cache the git status, but I decided
>> that I can personally live with that.
>> 
>> So what do you think about that? 
> 
> Well, avoiding >1 empty commits sounds good. I'm happy to go with your 
> assessment as you're more likely to be observing actual performance than me 
> (I'm not really monitoring the performance of buildhistory on our autobuilder, 
> only the output).
> 
> FYI I didn't comment on the splitting into separate commits patch earlier 
> because it doesn't really bother me either way. I do think people will find it 
> easier to use the buildhistory-diff tool rather than looking at the git log 
> directly (or the web-based equivalent when I finish that.); but I'm happy to 
> continue supporting those that prefer to read the log.
> 
>> If you like the idea, would you like it as follow up or as a respin of the
>> series?
> 
> Since it hasn't been merged I'll go for a respin, if you don't mind.

I'll respin and take Martins concerns in as well. Not sure when the new patchset will be sent, 2 weeks of tradeshows, bspfests and summits ahead :)

regards,

Koen