[OE-core] Libpng 1.6.x is broken, switch back to 1.5.x before release?

[Andreas Müller]

On Tue, Apr 16, 2013 at 11:06 AM, Koen Kooi <koen at dominion.thruhere.net> wrote:
> Hi,
>
> I've been looking into the libpng problems people have been reporting (e.g. #4060) and tried to upgrade 1.16.1 to fix those. Long story short, 1.16.1 doesn't fix them. I'm currently using weston as a testbed and was able to narrow the problems with weston down to:
>
>         cairo_surface_t *surface = cairo_image_surface_create_from_png(icon);
>
> with ends up as:
>
>         ERROR loading icon from file '/usr/share/icons/gnome/24x24/apps/utilities-terminal.png', error: 'out of memory'
>
> Reverting the 1.6.0 update and rebuilding cairo against 1.5.x makes it work, no errors in the log and I get window decorations instead of white squares. I'll see if I can get libpng-1.7.0beta07.tar.gz to build today, but I can't spend much time on that.
>
> All in all I'd recommend adding back the 1.5.x recipe and D_P -1'ing the 1.6.x recipe. Thanks to shlib renaming the resulting libpng packages are parallel installable and PRSERV takes care of bumping affected recipes/packages. Switching to 1.5.x "just works" if you have this patch:
>
> diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
> index f622903..c1beb9e 100644
> --- a/meta/recipes-graphics/pango/pango.inc
> +++ b/meta/recipes-graphics/pango/pango.inc
> @@ -10,7 +10,7 @@ SECTION = "libs"
>  LICENSE = "LGPLv2.0+"
>
>  X11DEPENDS = "virtual/libx11 libxft"
> -DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv cairo elfutils harfbuzz"
> +DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv cairo elfutils harfbuzz libpng"
>
> regards,
>
> Koen
I would like to bisect this - test case are the network-manager-applet
icons for WLAN. If libpng-1.7.0beta07 fixes let me know.

Andreas