[OE-core] [PATCH 4/7] oe-git-proxy: Add a new comprehensive git proxy script

Otavio Salvador otavio at ossystems.com.br
Sat Feb 9 17:02:06 UTC 2013


On Sat, Feb 9, 2013 at 2:59 PM, Darren Hart <dvhart at linux.intel.com> wrote:
>
>
> On 02/08/2013 06:43 PM, Otavio Salvador wrote:
>> On Fri, Feb 8, 2013 at 8:27 PM, Darren Hart <dvhart at linux.intel.com> wrote:
>>> oe-git-proxy.sh is a simple tool to be used via GIT_PROXY_COMMAND. It
>>> uses BSD netcat to make SOCKS5 or HTTPS proxy connections. It uses
>>> ALL_PROXY to determine the proxy server, protocol, and port. It uses
>>> NO_PROXY to skip using the proxy for a comma delimited list of hosts,
>>> host globs (*.example.com), IPs, or CIDR masks (192.168.1.0/24). It is
>>> known to work with both bash and dash shells.
>>>
>>> V2: Implement recommendations by Enrico Scholz:
>>>     o Use exec for the nc calls
>>>     o Use "$@" instead of $* to avoid quoting issues inherent with $*
>>>     o Use bash explicitly and simplify some of the string manipulations
>>>     Also:
>>>     o Drop the .sh in the name per Otavio Salvador
>>>     o Remove a stray debug statement
>>>
>>> V3: Implement recommendations by Otavio Salvador
>>>     o GPL license blurb
>>>     o Fix minor typo in comment block
>>>
>>> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
>>> Cc: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>
>>> Cc: Otavio Salvador <otavio at ossystems.com.br>
>>>
>>> git-proxy cleanup
>>
>> All those comments ought to be bellow --- or those will be included in
>> commit log.
>>
>
> Which is fine.

Well, usually the log of the revisions are not included in the commit
logs; any special reason for it to be done different?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br




More information about the Openembedded-core mailing list