[OE-core] [PATCH V2 1/9] busybox: remove the postinst part of the recipe

[Otavio Salvador]

On Mon, Jun 17, 2013 at 10:37 PM, ChenQi <Qi.Chen at windriver.com> wrote:
> On 06/18/2013 01:52 AM, Otavio Salvador wrote:
>>
>> On Mon, Jun 17, 2013 at 2:49 AM,  <Qi.Chen at windriver.com> wrote:
>>>
>>> From: Chen Qi <Qi.Chen at windriver.com>
>>>
>>> Remove the pkg_postinst_${PN} from this recipe, as it's redundant.
>>> It basically wants to do the same thing as the update-alternatives
>>> does. But it doesn't do it well.
>>>
>>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>>
>> Most of patch 1 and 2 should be merged; here you should drop the
>> postinst and convert these to the update-alternative way so we don't
>> have the tree broken after this patch and allow for bisect  to be
>> used.
>
> Hi Otavio,
>
> Maybe there's some misunderstanding here.
> To be clear, patch 1 and patch 2 do two different things.
> Patch 1 removes postinst, it has nothing to do with patch 2, which fix
> busybox.inc to support the FEATURE_INDIVIDUAL.
> And after this patch (patch 1), the tree is not broken. The busybox still
> works as it has been working so far.
>
> [
> And I just did a simple test to confirm this. On the lastest master, I
> removed the postinst part of busybox.inc, and built a core-image-minimal, it
> worked out well. Here's some output.
> root at qemuarm:~# ls -l /bin/ | grep busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 ash -> /bin/busybox
> -rwsr-xr-x    1 root     root        556824 Jun 18 01:27 busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 cat -> /bin/busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 chattr ->
> /bin/busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 chgrp ->
> /bin/busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 chmod ->
> /bin/busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 chown ->
> /bin/busybox
> lrwxrwxrwx    1 root     root            12 Jun 18 01:31 cp -> /bin/busybox
> ....
> ]

Oh I see.

So I have no objection for the patch :-)

Thanks by letting me know.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750