[OE-core] [PATCH v3 1/2] wayland : Bump to 1.2.0 version
Ewan LE BIDEAU-CANEVET
ewan.lebideau-canevet at eurogiciel.fr
Thu Oct 10 15:44:59 UTC 2013
On 10/10/2013 16:16, Burton, Ross wrote:
> On 10 October 2013 13:23, Ewan LE BIDEAU-CANEVET
> <Ewan.LEBIDEAU-CANEVET at eurogiciel.fr> wrote:
>> -SRC_URI_append_class-native = " file://just-scanner.patch"
> That patch - as it says - serves a useful purpose. What is the
> rationale for deleting it? If there's a good reason, please say what
> it is.
>
>> -# Wayland installs a M4 macro for other projects to use. This M4 macro includes
>> -# a path to a Makefile fragment to get the rules to generate stubs from protocol
>> -# description files. The paths to the sysroot end up incorrect, so fix them.
>> -do_configure_append_class-native() {
>> - sed -e 's, at prefix@,${STAGING_DIR_NATIVE},g' \
>> - -e 's, at exec_prefix@,${STAGING_DIR_NATIVE},g' \
>> - -e 's, at bindir@,${STAGING_BINDIR_NATIVE},g' \
>> - -e 's, at datarootdir@,${STAGING_DATADIR_NATIVE},g' \
>> - ${S}/wayland-scanner.m4.in > ${B}/wayland-scanner.m4
>> -}
> Wayland is still installing this m4 file, so why delete this fix?
> From a glance at Wayland 1.2 it looks like it isn't required anymore
> as pkgconfig is used to determine the paths, but you need to state
> this in the commit message.
This file
wayland-scanner.m4*.**in** *
doesn't exist anymore. In fact there is only "wayland-scanner.m4"
Run sed command on a missing file wayland-scanner.m4.in is now
useless, correct ?
Furthermore, in wayland-scanner.m4 has no reference to strings
@prefix@
@exec_prefix@
@bindir@
@datarootdir@
So if we let this instruction wayland-scanner.m4 will be cleared. So
this leads to build faillure.
> Also, there's a 1.2.1 release now.
You're right :). I have started this work few weeks ago.
I noticed that there is a 1.3.0 version, and I have started to take a
look on it. I'll probably post my work in 1 or 2 weeks.
As I saw , we need to do the same change (Remove :
do_configure_append_class-native function => last existing
wayland-scanner.m4.in was in 1.1.0 version.)
Apologies for removing your just-scanner.patch file, my mistake.
Ewan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20131010/a8fdbadd/attachment-0002.html>
More information about the Openembedded-core
mailing list