[OE-core] [PATCH v3 1/2] wayland : Bump to 1.2.0 version

Burton, Ross ross.burton at intel.com
Thu Oct 10 15:59:09 UTC 2013


On 10 October 2013 16:44, Ewan LE BIDEAU-CANEVET
<ewan.lebideau-canevet at eurogiciel.fr> wrote:
> Wayland is still installing this m4 file, so why delete this fix?
> From a glance at Wayland 1.2 it looks like it isn't required anymore
> as pkgconfig is used to determine the paths, but you need to state
> this in the commit message.
>
> This file
>
> wayland-scanner.m4.in
>
> doesn't exist anymore. In fact there is only "wayland-scanner.m4"
> Run sed command on a missing  file wayland-scanner.m4.in  is now useless,
> correct ?
> Furthermore, in wayland-scanner.m4 has no reference to strings
>
> @prefix@
> @exec_prefix@
> @bindir@
> @datarootdir@
>
> So if we let this instruction wayland-scanner.m4 will  be cleared. So this
> leads to build faillure.

Sure, but this rationale needs to be in the commit message, ideally
after verifying that the pkgconfig file doesn't have the same problem
that the m4 had.

Ross



More information about the Openembedded-core mailing list