[OE-core] [PATCH] systemd: Check for HAVE_POSIX_FALLOCATE

Khem Raj raj.khem at gmail.com
Mon Apr 28 17:10:22 UTC 2014


On Mon, Apr 28, 2014 at 8:38 AM, Drew Moseley <drew at moseleynet.net> wrote:
> From: Drew Moseley <drew_moseley at mentor.com>
>
> The check for the config variable is using the wrong define
> resulting in the #else always being used.
>

good catch. Looks good to me Thanks for the patch.

> Signed-off-by: Drew Moseley <drew_moseley at mentor.com>
> ---
>  .../systemd/systemd-pam-fix-fallocate.patch        |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch b/meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
> index de73be9..d25acef 100644
> --- a/meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
> +++ b/meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
> @@ -27,7 +27,7 @@ Index: systemd-209/src/journal/journal-file.c
>           /* Note that the glibc fallocate() fallback is very
>              inefficient, hence we try to minimize the allocation area
>              as we can. */
> -+#ifdef HAVE_POSIX_ALLOCATE
> ++#ifdef HAVE_POSIX_FALLOCATE
>           r = posix_fallocate(f->fd, old_size, new_size - old_size);
>           if (r != 0)
>                   return -r;
> @@ -66,7 +66,7 @@ Index: systemd-209/src/journal/journald-kmsg.c
>           }
>  -
>  -        if (posix_fallocate(fd, 0, sizeof(uint64_t)) < 0) {
> -+#ifdef HAVE_POSIX_ALLOCATE
> ++#ifdef HAVE_POSIX_FALLOCATE
>  +        r = posix_fallocate(fd, 0, sizeof(uint64_t));
>  +#else
>  +      /* Use good old method to write zeros into the journal file
> --
> 1.7.9.5
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



More information about the Openembedded-core mailing list