[OE-core] [PATCH] systemd: Check for HAVE_POSIX_FALLOCATE

[Drew Moseley]

On Apr 28, 2014, at 1:10 PM, Khem Raj <raj.khem at gmail.com> wrote:
> On Mon, Apr 28, 2014 at 8:38 AM, Drew Moseley <drew at moseleynet.net> wrote:
>> From: Drew Moseley <drew_moseley at mentor.com>
>> 
>> The check for the config variable is using the wrong define
>> resulting in the #else always being used.
>> 
> 
> good catch. Looks good to me Thanks for the patch.

Hi Khem,

I'm curious about the safety of using alloca() here. In my
particular config, without the fix to use posix_fallocate(), it was
attempting to allocate 8MB on the stack, evidently failing, and
then segfaulting.  And there is evidently no error return value
from alloca so any time it fails a segfault is the likely result.

Thoughts?

Drew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140428/c9447931/attachment-0002.html>