[OE-core] [PATCH] weston : refactor to identify EGL, cairoglesv2 support

[Otavio Salvador]

On Fri, Mar 28, 2014 at 11:28 AM, Valentin Popa <valentin.popa at intel.com> wrote:
> On 03/28/2014 03:55 PM, Otavio Salvador wrote:
>>
>> On Fri, Mar 28, 2014 at 10:37 AM, Valentin Popa <valentin.popa at intel.com>
>> wrote:
>>>
>>> On 03/28/2014 03:35 PM, Otavio Salvador wrote:
>>>>
>>>> On Fri, Mar 28, 2014 at 10:28 AM, Valentin Popa
>>>> <valentin.popa at intel.com>
>>>> wrote:
>>>>>
>>>>> On 03/28/2014 02:53 PM, Otavio Salvador wrote:
>>>>>>
>>>>>> On Fri, Mar 28, 2014 at 9:23 AM, Valentin Popa
>>>>>> <valentin.popa at intel.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> On 03/27/2014 08:09 PM, Otavio Salvador wrote:
>>>>>>>>
>>>>>>>> On Thu, Mar 27, 2014 at 9:30 AM, Valentin Popa
>>>>>>>> <valentin.popa at intel.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> On 03/26/2014 11:07 PM, Otavio Salvador wrote:
>>>>>>>>>>
>>>>>>>>>> From: Prabhu Sundararaj <prabhu.sundararaj at freescale.com>
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Prabhu Sundararaj <prabhu.sundararaj at freescale.com>
>>>>>>>>>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>>>>>>>>>> ---
>>>>>>>>>>       meta/recipes-graphics/wayland/weston_1.4.0.bb | 7 +++++--
>>>>>>>>>>       1 file changed, 5 insertions(+), 2 deletions(-)
>>>>>>>>>>
>>>>>>>>>> diff --git a/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>>>>>>>>> b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>>>>>>>>> index e0c354d..a41b5cd 100644
>>>>>>>>>> --- a/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>>>>>>>>> +++ b/meta/recipes-graphics/wayland/weston_1.4.0.bb
>>>>>>>>>> @@ -23,7 +23,6 @@ EXTRA_OECONF = "--enable-setuid-install \
>>>>>>>>>>                       --enable-simple-clients \
>>>>>>>>>>                       --enable-clients \
>>>>>>>>>>                       --enable-demo-clients-install \
>>>>>>>>>> -                --disable-simple-egl-clients \
>>>>>>>>>>                       --disable-libunwind \
>>>>>>>>>>                       --disable-rpi-compositor \
>>>>>>>>>>                       --disable-rdp-compositor"
>>>>>>>>>> @@ -39,7 +38,7 @@ PACKAGECONFIG ??=
>>>>>>>>>> "${@base_contains('DISTRO_FEATURES',
>>>>>>>>>> 'wayland', 'kms fbdev way
>>>>>>>>>>       # Weston on KMS
>>>>>>>>>>       PACKAGECONFIG[kms] =
>>>>>>>>>> "--enable-drm-compositor,--disable-drm-compositor,drm udev
>>>>>>>>>> virtual/mesa
>>>>>>>>>> mtdev"
>>>>>>>>>>       # Weston on Wayland (nested Weston)
>>>>>>>>>> -PACKAGECONFIG[wayland] =
>>>>>>>>>> "--enable-wayland-compositor,--disable-egl
>>>>>>>>>> --disable-wayland-compositor,virtual/mesa"
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> We need --disable-egl if wayland is not in DISTRO_FEATURES. See
>>>>>>>>> bug:
>>>>>>>>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=5867
>>>>>>>>
>>>>>>>> As egl is not part of PACKAGECONFIG it will do the right thing, no?
>>>>>>>>
>>>>>>> Yes, it will. My concerns are about --enable-drm-compositor (kms)
>>>>>>> without
>>>>>>> egl; I know that the user can pass at runtime the --use-pixman flag,
>>>>>>> but
>>>>>>> I
>>>>>>> think it's more important to keep egl enabled by default in weston
>>>>>>> (this
>>>>>>> is
>>>>>>> probably the main "usecase" of wayland/weston). So if you enable egl,
>>>>>>> the
>>>>>>> bug will reproduce.
>>>>>>
>>>>>> The PACKAGECONFIG is for flexibility and so we are using it here as it
>>>>>> is designed. I understand we still don't have a way to map config
>>>>>> dependencies but this is no excuse to say the patch is wrong or
>>>>>> inappropriate.
>>>>>>
>>>>>> We are using this in the upcoming i.MX6 Wayland support we sent to
>>>>>> meta-fsl-arm and the only blocker is this patch be accepted.
>>>>>>
>>>>> The patch is not wrong, but disables egl. Looks good to me and if
>>>>> merged
>>>>> I'll submit a patch to add egl in PACKAGECONFIG.
>>>>
>>>> If you want, I can add the egl there, and send v2. That's easy.
>>>
>>> That would be great. And don't forget to --disable-egl in case wayland is
>>> not in PACKAGECONFIG.
>>
>> This is the point I don't agree. I think user needs to drop egl when
>> dropping wayland.
>>
> Makes sens. So you need:
> PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'wayland', 'egl kms
> fbdev wayland', '', d)} \

I sent the v2; please take a look there.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750