[OE-core] [PATCH] binutils: Allow gold to build even when not the default

[Khem Raj]

> On Apr 7, 2015, at 2:56 PM, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
> 
> On Tue, 2015-04-07 at 12:33 -0700, Khem Raj wrote:
>>> On Apr 7, 2015, at 7:51 AM, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
>>> 
>>> It can be useful to have gold available for testing even when its not the
>>> default, therefore build gold by default in all configurations.
>>> 
>>> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>>> 
>>> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
>>> index afb582a..3c65efc 100644
>>> --- a/meta/recipes-devtools/binutils/binutils.inc
>>> +++ b/meta/recipes-devtools/binutils/binutils.inc
>>> @@ -73,7 +73,7 @@ EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
>>> 
>>> LDGOLD_class-native = ""
>>> LDGOLD_class-crosssdk = ""
>>> -LDGOLD ?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default --enable-threads', '', d)}"
>>> +LDGOLD ?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default --enable-threads', '--enable-gold --enable-ld=default', d)}”
>>> 
>> 
>> may be enable-gold could be done unconditionally ? and then —enable-gold|ld=default controlled with ld-is-gold ?
>> ld-is-gold anyway meant that default linker is gold, it did not mean
>> to just build gold, so we are not changing semantics
> 
> The above effectively does mean we're always building gold, it just
> controls whether ld is gold or not as before?
> 

yes but only for cross toolchain. I was suggesting was to incorporate —enable-gold generally for all binutils variants
while keeping ld.bfd as default. 

> Cheers,
> 
> Richard