[OE-core] [PATCH] selftest/buildoptions.py: correct small mistake cleanupworkdir ---> cleanup-workdir

[Constantin, Costin C]

appologies for this one Paul. I'll wipe out the workdir clean

-----Original Message-----
From: Paul Eggleton [mailto:paul.eggleton at linux.intel.com] 
Sent: Friday, August 07, 2015 2:31 PM
To: Constantin, Costin C
Cc: openembedded-core at lists.openembedded.org
Subject: Re: [OE-core] [PATCH] selftest/buildoptions.py: correct small mistake cleanupworkdir ---> cleanup-workdir

Hi Costin,

On Friday 07 August 2015 14:17:02 Costin Constantin wrote:
> Signed-off-by: Costin Constantin <costin.c.constantin at intel.com>
> ---
>  meta/lib/oeqa/selftest/buildoptions.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/lib/oeqa/selftest/buildoptions.py
> b/meta/lib/oeqa/selftest/buildoptions.py index 483803b..655b5da 100644
> --- a/meta/lib/oeqa/selftest/buildoptions.py
> +++ b/meta/lib/oeqa/selftest/buildoptions.py
> @@ -128,7 +128,7 @@ class BuildImagesTest(oeSelfTest):
>          This method is used to test the build of directfb image for 
> arm arch. In essence we build a coreimagedirectfb and test the 
> exitcode of bitbake that in case of success is 0. """
> -        self.add_command_to_tearDown('cleanupworkdir')
> +        self.add_command_to_tearDown('cleanup-workdir')
>          self.write_config("DISTRO_FEATURES_remove = 
> \"x11\"\nDISTRO_FEATURES_append = \" directfb\"\nMACHINE ??= 
> \"qemuarm\"") res = bitbake("core-image-directfb", ignore_status=True)
>          self.assertEqual(res.status, 0, "\ncoreimagedirectfb failed 
> to build. Please check logs for further details.\nbitbake output %s" %
> res.output) @@ -139,7 +139,7 @@ class ArchiverTest(oeSelfTest):
>          """
>          Test for archiving the work directory and exporting the 
> source files. """
> -        self.add_command_to_tearDown('cleanupworkdir')
> +        self.add_command_to_tearDown('cleanup-workdir')
>          self.write_config("INHERIT = \"archiver\"\nARCHIVER_MODE[src] 
> = \"original\"\nARCHIVER_MODE[srpm] = \"1\"") res = 
> bitbake("xcursor-transparent-theme", ignore_status=True) 
> self.assertEqual(res.status, 0, "\nCouldn't build 
> xcursortransparenttheme.\nbitbake output %s" % res.output)

I think we talked about this in another test - we shouldn't be calling cleanup-workdir as part of any of our tests. If we need to clean specific recipes that were built by the tests that's fine, but cleanup-workdir blasts everything away which isn't really appropriate.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre