[OE-core] [PATCH v3] "Finish" the IMAGE_GEN_DEBUGFS implementation

Mark Hatle mark.hatle at windriver.com
Fri Oct 2 15:25:20 UTC 2015


V3: (hopefully final)
Fixed the comparison by adding the prefix into the image_cmd data structure.
That ensures we're only comparing the prefix and not the whole pathname.

Also changed the bb.note slightly to indicate which path we tool through
the processing in case of future problems.

V2:
By adjusting the _write_script function (and associated _get_imagecmds) the
script may optionally pass in a prefix for the generated script.  This solves
one of the problems in the prior version.  (No more script name collisions.)

The second issue is that the datastore is used to find various parameters
(which are different in the DEBUGFS datastore) when doing the final symlink
generation.

So we do have to switch (based on the script prefix) which datastore we
should be using.  (Note, I'm not completely sure that the switch is 'safe',
so this is an area that should be verified.)

V1:

It was noticed today that the IMAGE_GEN_DEBUGFS implementation was not 
complete.  The version that was merged back in May only contained the 
filesystem generation pieces, but not the pieces for creating the image
from that filesystem.

The code has been tested and is working.  The only thing that I don't 
particularly like is that the processing code and loop is a duplicate of
the code that runs just before.  Unfortunately the only way around this
is to change the way that way the parallel bits are processed to support
multiple datastores..  (or create "another" function..)

Any feedback appreciated, but without this the feature is broken!


Mark Hatle (1):
  lib/oe/image.py: Add image generation for companion debug filesystem

 meta/conf/documentation.conf         |  2 ++
 meta/conf/local.conf.sample.extended |  9 +++++++
 meta/lib/oe/image.py                 | 46 +++++++++++++++++++++++++++++-------
 3 files changed, 48 insertions(+), 9 deletions(-)

-- 
1.9.3



More information about the Openembedded-core mailing list