[OE-core] [PATCH v2] "Finish" the IMAGE_GEN_DEBUGFS implementation
Mark Hatle
mark.hatle at windriver.com
Fri Oct 2 14:57:22 UTC 2015
On 10/2/15 9:53 AM, Mark Hatle wrote:
> V2:
> By adjusting the _write_script function (and associated _get_imagecmds) the
> script may optionally pass in a prefix for the generated script. This solves
> one of the problems in the prior version. (No more script name collisions.)
>
> The second issue is that the datastore is used to find various parameters
> (which are different in the DEBUGFS datastore) when doing the final symlink
> generation.
>
> So we do have to switch (based on the script prefix) which datastore we
> should be using. (Note, I'm not completely sure that the switch is 'safe',
> so this is an area that should be verified.)
And I verified, it is indeed not safe..
The script name is set by:
script_name = os.path.join(tempdir, sprefix + "create_image." + type)
So I'd need to exclude the tempdir ($T) in order for the test to be right.. and
even then it probably should be a 'startwith' comparison?
Does this seem right to others?
--Mark
> V1:
>
> It was noticed today that the IMAGE_GEN_DEBUGFS implementation was not
> complete. The version that was merged back in May only contained the
> filesystem generation pieces, but not the pieces for creating the image
> from that filesystem.
>
> The code has been tested and is working. The only thing that I don't
> particularly like is that the processing code and loop is a duplicate of
> the code that runs just before. Unfortunately the only way around this
> is to change the way that way the parallel bits are processed to support
> multiple datastores.. (or create "another" function..)
>
> Any feedback appreciated, but without this the feature is broken!
>
> Mark Hatle (1):
> lib/oe/image.py: Add image generation for companion debug filesystem
>
> meta/conf/documentation.conf | 2 ++
> meta/conf/local.conf.sample.extended | 9 +++++++++
> meta/lib/oe/image.py | 37 +++++++++++++++++++++++++++++++-----
> 3 files changed, 43 insertions(+), 5 deletions(-)
>
More information about the Openembedded-core
mailing list