[OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

[Carlos Alberto Lopez Perez]

On 10/10/15 17:32, Martin Jansa wrote:
> Did you enable thumb in that build? It's not enabled by default.
> 
> ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
> default.

I assumed it was enabled by default if it was listed on the list printed
on TUNE_FEATURES when starting bitbake. Seems not.

I manually enabled it on the recipe of webkitgtk+ by setting
'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
failure.

However, later I tried doing the same for a standard armv7a machine and
it built fine.

qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
thumb2 instead. The compiler would automatically use thumb2 when
enabling -mthumb on a armv7 or newer march.

So, it built fine with -march=armv7-a -mthumb

Given that most people building webkitgtk+ will use armv7 or newer, I
don't think disabling the possibility of building webkitgtk+ with thumb
(thumb2) unconditionally is a good idea.

I also tested to build gcr and libsecret. Both build also fine with
-mthumb on armv7.


So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
machines in this 3 recipes?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 883 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20151010/2f7f915a/attachment-0002.sig>