[OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

[Khem Raj]

On Sat, Oct 10, 2015 at 2:45 PM, Carlos Alberto Lopez Perez
<clopez at igalia.com> wrote:
> On 10/10/15 17:32, Martin Jansa wrote:
>> Did you enable thumb in that build? It's not enabled by default.
>>
>> ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
>> default.
>
> I assumed it was enabled by default if it was listed on the list printed
> on TUNE_FEATURES when starting bitbake. Seems not.
>
> I manually enabled it on the recipe of webkitgtk+ by setting
> 'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
> failure.
>
> However, later I tried doing the same for a standard armv7a machine and
> it built fine.
>
> qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
> thumb2 instead. The compiler would automatically use thumb2 when
> enabling -mthumb on a armv7 or newer march.
>
> So, it built fine with -march=armv7-a -mthumb

that will use thumb2 ISA and its not same as thumb1 that Martin is seeing.

>
> Given that most people building webkitgtk+ will use armv7 or newer, I
> don't think disabling the possibility of building webkitgtk+ with thumb
> (thumb2) unconditionally is a good idea.
>
> I also tested to build gcr and libsecret. Both build also fine with
> -mthumb on armv7.
>
>
> So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
> machines in this 3 recipes?

I think that should be fine. Although we don't have a single check for this
one needs to check for armv5 and armv4 and its family of sub-arches

>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>