[OE-core] can "IMAGE_INSTALL ?= ..." not be written in a more obvious way?

Khem Raj raj.khem at gmail.com
Sat Dec 10 21:15:47 UTC 2016


On Sat, Dec 10, 2016 at 3:40 AM, Robert P. J. Day <rpjday at crashcourse.ca> wrote:
>
>   i've nattered about this before but not sure i ever got an answer --
> here's the last bit of core-image.bbclass:
>
>   CORE_IMAGE_BASE_INSTALL = '\
>     packagegroup-core-boot \
>     packagegroup-base-extended \
>     \
>     ${CORE_IMAGE_EXTRA_INSTALL} \
>     '
>
>   CORE_IMAGE_EXTRA_INSTALL ?= ""
>
>   IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}"
>
> the first time i saw that (long ago), it took me a few looks to figure
> out what was happening. can this not be written in a more obvious way:
>
>   CORE_IMAGE_BASE_INSTALL = '\
>     packagegroup-core-boot \
>     packagegroup-base-extended \
>     '
>
>   CORE_IMAGE_EXTRA_INSTALL ?= ""
>
>   IMAGE_INSTALL ?= " \
>     ${CORE_IMAGE_BASE_INSTALL} \
>     ${CORE_IMAGE_EXTRA_INSTALL} \
>     "
>
> is that not equivalent, or am i missing something? it's certainly
> clearer as to what's happening if people are perusing the code.

They are same AFAICT, dont feel strongly  about readability but feel
free to send a patch



More information about the Openembedded-core mailing list