[OE-core] [PATCH v2 23/28] Revert "classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable"

Aníbal Limón anibal.limon at linux.intel.com
Thu Feb 4 20:38:56 UTC 2016


Comments below,

On 02/04/2016 02:19 PM, Paul Eggleton wrote:
> On Thu, 04 Feb 2016 14:12:40 Aníbal Limón wrote:
>> On 02/04/2016 12:34 PM, Paul Eggleton wrote:
>>> On Tue, 02 Feb 2016 18:30:35 Aníbal Limón wrote:
>>>> This reverts commit 303985d3f402013c7c4a3355f19d48b1cef1c12f.
>>>>
>>>> As discussion with Paul Eggleton, he don't want to have env variables
>>>> to change the behaviour of what the env script needs to print,
>>>> i'll redirect the output in oeSDK.run() method.
>>>>
>>>> I didn't agree because it can hides another messages like error ones
>>>> and with the variable you can control what prints or not.
>>>>
>>>> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
>>>
>>> We don't want to add this and revert it in the same series.
>>
>> Ok, then i'll send another series without this commit and this revert in
>> another commit.
> 
> If you mean without both the commit and the revert, then yes.
> 

No i don't mean that way because i don't agree with this change and i
consider this as *CENSURE* because if i someone don't agree a change the
why? information need to be placed in the git repository for future
references.

I'll make the changes that you requested to drop the two commits (i'm
still disagree) for don't stop the process of integrate the eSDK tests
that we need for a some time ago.


Cheers,
	alimon

> Cheers,
> Paul
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160204/eb0fe166/attachment-0002.sig>


More information about the Openembedded-core mailing list