[OE-core] [PATCH v2 23/28] Revert "classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable"

[Paul Eggleton]

On Thu, 04 Feb 2016 14:38:56 Aníbal Limón wrote:
> Comments below,
> 
> On 02/04/2016 02:19 PM, Paul Eggleton wrote:
> > On Thu, 04 Feb 2016 14:12:40 Aníbal Limón wrote:
> >> On 02/04/2016 12:34 PM, Paul Eggleton wrote:
> >>> On Tue, 02 Feb 2016 18:30:35 Aníbal Limón wrote:
> >>>> This reverts commit 303985d3f402013c7c4a3355f19d48b1cef1c12f.
> >>>> 
> >>>> As discussion with Paul Eggleton, he don't want to have env variables
> >>>> to change the behaviour of what the env script needs to print,
> >>>> i'll redirect the output in oeSDK.run() method.
> >>>> 
> >>>> I didn't agree because it can hides another messages like error ones
> >>>> and with the variable you can control what prints or not.
> >>>> 
> >>>> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
> >>> 
> >>> We don't want to add this and revert it in the same series.
> >> 
> >> Ok, then i'll send another series without this commit and this revert in
> >> another commit.
> > 
> > If you mean without both the commit and the revert, then yes.
> 
> No i don't mean that way because i don't agree with this change and i
> consider this as *CENSURE* because if i someone don't agree a change the
> why? information need to be placed in the git repository for future
> references.

We don't put the entire history of decisions on a change in the git history 
(certainly not in the form of commit and revert, anyway) or it would be really 
hard to follow when looking back in future. If you want to record that we 
discussed this alternative solution, the place to do it would be in the commit 
message where you make the redirection change, which was the alternative to 
this.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre