[OE-core] [PATCH] nss: Explicitly link with libssp on musl/ppc

[Khem Raj]

> On Mar 24, 2016, at 9:20 AM, Phil Blundell <pb at pbcl.net> wrote:
> 
> On Thu, 2016-03-24 at 15:24 +0000, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> 
> This is all a bit obscure.  Please add an explanation of why this is
> needed specifically by ppc (and not other architectures) to the commit
> message.

It is using nodefaultlib on linker cmdline and as a result, it was complaining
about missing __stack_chk_fail_local which was being added by compiler due
to -fstack-protector-strong being in CFLAGS, I did not look into roots as to
why it was showing up on ppc only.

> 
> Also, the subject says "musl" but the patch doesn't seem to be
> obviously specific to musl.  Is SECURITY_LDFLAGS not used at all by
> other libcs?

It does not harm others.

> 
> p.
> 
>> ---
>>  meta/recipes-support/nss/nss_3.21.bb | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta/recipes-support/nss/nss_3.21.bb b/meta/recipes-
>> support/nss/nss_3.21.bb
>> index d2e2411..9f2626b 100644
>> --- a/meta/recipes-support/nss/nss_3.21.bb
>> +++ b/meta/recipes-support/nss/nss_3.21.bb
>> @@ -41,6 +41,7 @@ TD = "${S}/tentative-dist"
>>  TDS = "${S}/tentative-dist-staging"
>> 
>>  TARGET_CC_ARCH += "${LDFLAGS}"
>> +SECURITY_LDFLAGS_append_powerpc = " -lssp_nonshared -lssp"
>> 
>>  do_configure_prepend_libc-musl () {
>>      sed -i -e '/-DHAVE_SYS_CDEFS_H/d'
>> ${S}/nss/lib/dbm/config/config.mk
>> --
>> 1.8.3.1
>> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160324/95b5d66d/attachment-0002.sig>