[OE-core] [PATCH] nss: Explicitly link with libssp on musl/ppc

[Khem Raj]

On Thu, Mar 24, 2016 at 9:20 AM, Phil Blundell <pb at pbcl.net> wrote:
> On Thu, 2016-03-24 at 15:24 +0000, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>
> This is all a bit obscure.  Please add an explanation of why this is
> needed specifically by ppc (and not other architectures) to the commit
> message.
>
> Also, the subject says "musl" but the patch doesn't seem to be
> obviously specific to musl.  Is SECURITY_LDFLAGS not used at all by
> other libcs?
>

This patch is not required anymore.

I took another dig at it and it turned out to be a bug in gcc for
musl, where it did not
detect libc's support for ssp correctly during configure as a result,
it would generate
wrong calls for __stack_chk_guard which were then marked with absolute
relocations
that linker could not resolve and spewed errors

See the latest pull request for more details.

http://patchwork.openembedded.org/patch/118829/

Thanks for raising concerns for this patch.

> p.
>
>> ---
>>  meta/recipes-support/nss/nss_3.21.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-support/nss/nss_3.21.bb b/meta/recipes-
>> support/nss/nss_3.21.bb
>> index d2e2411..9f2626b 100644
>> --- a/meta/recipes-support/nss/nss_3.21.bb
>> +++ b/meta/recipes-support/nss/nss_3.21.bb
>> @@ -41,6 +41,7 @@ TD = "${S}/tentative-dist"
>>  TDS = "${S}/tentative-dist-staging"
>>
>>  TARGET_CC_ARCH += "${LDFLAGS}"
>> +SECURITY_LDFLAGS_append_powerpc = " -lssp_nonshared -lssp"
>>
>>  do_configure_prepend_libc-musl () {
>>      sed -i -e '/-DHAVE_SYS_CDEFS_H/d'
>> ${S}/nss/lib/dbm/config/config.mk
>> --
>> 1.8.3.1
>>