[OE-core] [OE-Core][PATCH 0/9] Add MIPS release 6 ISA support

[Zubair Lutfullah Kakakhel]

Hi,

On 10/07/2016 04:48 PM, Richard Purdie wrote:
> On Fri, 2016-10-07 at 12:53 +0100, Zubair Lutfullah Kakakhel wrote:
>> On 10/06/2016 05:43 PM, Mark Hatle wrote:
>>>
>>> A few general comments.  I don't see an n32 variant
>>> implemented.  I'd suggest a
>>> follow on patch (vs a new version) to add n32.
>>>
>>> It looks like it's missing in the files modified by patches 6-9.
>> Thanks for the review.
>> Yes I haven't added the n32 variant on purpose at the moment.
>> Wanted to get this out to see if this is the correct approach.
>
> I've been torn on these patches, they're good but they've come in very
> late in the cycle for this kind of change. Since they're comparatively
> straight forward to review, I've merged them. This is partly because I
> wouldn't really want to backport changes like this later and it seemed
> likely that might be requested.

Thank you very much for merging them this cycle!

>
> What I will say though is that we really need to think about an
> "allmips", or "mipsarch" override, rather than all these duplicate
> lines for all mips variants. This is something we should fix early in
> the 2.3 cycle and should make some of this look a lot neater. It might
> be worth openening a bug for this in the bugzilla and assigning that to
> yourself, assuming you're happy to work on it?

The duplicate lines are bothersome indeed.
I'm happy to work on it. But I'm still a bit new to OE internals so would
prefer a little direction regarding the best approach to take.

Regards,
ZubairLK

>
> Cheers,
>
> Richard
>
>