[OE-core] [OE-Core][PATCH 0/9] Add MIPS release 6 ISA support

Richard Purdie richard.purdie at linuxfoundation.org
Fri Oct 7 16:19:49 UTC 2016


On Fri, 2016-10-07 at 17:07 +0100, Zubair Lutfullah Kakakhel wrote:
> On 10/07/2016 04:48 PM, Richard Purdie wrote:
> > On Fri, 2016-10-07 at 12:53 +0100, Zubair Lutfullah Kakakhel wrote:
> > What I will say though is that we really need to think about an
> > "allmips", or "mipsarch" override, rather than all these duplicate
> > lines for all mips variants. This is something we should fix early
> > in
> > the 2.3 cycle and should make some of this look a lot neater. It
> > might
> > be worth openening a bug for this in the bugzilla and assigning
> > that to
> > yourself, assuming you're happy to work on it?
> The duplicate lines are bothersome indeed.
> I'm happy to work on it. But I'm still a bit new to OE internals so
> would
> prefer a little direction regarding the best approach to take.

Very roughly speaking, you'd add something like:

MACHINEOVERRIDES =. "mipsarch"

to arch-mips.inc then you could do:

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 54a587f..7bd8716 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -528,16 +528,7 @@ BUILDSDK_LDFLAGS = "-Wl,-O1"
 
 LINKER_HASH_STYLE ??= "gnu"
 # mips does not support GNU hash style therefore we override
-LINKER_HASH_STYLE_mips = "sysv"
-LINKER_HASH_STYLE_mipsel = "sysv"
-LINKER_HASH_STYLE_mips64 = "sysv"
-LINKER_HASH_STYLE_mips64el = "sysv"
-LINKER_HASH_STYLE_mips64n32 = "sysv"
-LINKER_HASH_STYLE_mips64eln32 = "sysv"
-LINKER_HASH_STYLE_mipsisa32r6 = "sysv"
-LINKER_HASH_STYLE_mipsisa32r6el = "sysv"
-LINKER_HASH_STYLE_mipsisa64r6 = "sysv"
-LINKER_HASH_STYLE_mipsisa64r6el = "sysv"
+LINKER_HASH_STYLE_mipsarch = "sysv"
 
 TARGET_LINK_HASH_STYLE ?= "${@['-Wl,--hash-style=gnu',''][d.getVar('LINKER_HASH_STYLE', True) != 'gnu']}"

amongst other nice cleanups.

Cheers,

Richard



More information about the Openembedded-core mailing list