[OE-core] [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

Andre McCurdy armccurdy at gmail.com
Wed Aug 23 02:19:25 UTC 2017


On Mon, Aug 21, 2017 at 4:43 AM,  <liu.ming50 at gmail.com> wrote:
> From: Ming Liu <peter.x.liu at external.atlascopco.com>
>
> To give a example:
> Before the change, in our build console, TUNE_FEATURES looks like:
> ...
> TUNE_FEATURES     = "arm armv7a vfp  neon        cortexa8"
> ...
>
> After the change:
> ...
> TUNE_FEATURES     = "arm armv7a vfp neon cortexa8"
> ...
>
> Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
> ---
>  meta/classes/base.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 8c86977..07734ac 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -206,7 +206,7 @@ def buildcfg_vars(d):
>      for var in statusvars:
>          value = d.getVar(var)
>          if value is not None:
> -            yield '%-17s = "%s"' % (var, value)
> +            yield '%-17s = "%s"' % (var, " ".join(value.split()))

This fix has been rejected once already:

  http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129358.html

The preferred alternative was to remove all duplicated whitespace in
the BUILDCFG_VARS variables:

  http://git.openembedded.org/openembedded-core/commit/?id=5610c6397ee098dd998b7417b343494de77179f9
  http://git.openembedded.org/openembedded-core/commit/?id=971e43270173afb08f21ffac16a4157f7e611b81

>  def buildcfg_neededvars(d):
>      needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



More information about the Openembedded-core mailing list