[OE-core] [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Ming Liu]

Hi, Andre:

Arha, I did not know that when I was submitting the patch, may I know why
it's rejected at that moment? Since even with the alternative fixes, the
developers still could introduce duplicated whitespaces in their BSP layers
if they do not know the rules, since it's quite common in recipes to assign
variables with duplicated whitespcaces.

BTW: i just checked, it's been merged to master already.

//Ming Liu

2017-08-23 4:19 GMT+02:00 Andre McCurdy <armccurdy at gmail.com>:

> On Mon, Aug 21, 2017 at 4:43 AM,  <liu.ming50 at gmail.com> wrote:
> > From: Ming Liu <peter.x.liu at external.atlascopco.com>
> >
> > To give a example:
> > Before the change, in our build console, TUNE_FEATURES looks like:
> > ...
> > TUNE_FEATURES     = "arm armv7a vfp  neon        cortexa8"
> > ...
> >
> > After the change:
> > ...
> > TUNE_FEATURES     = "arm armv7a vfp neon cortexa8"
> > ...
> >
> > Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
> > ---
> >  meta/classes/base.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > index 8c86977..07734ac 100644
> > --- a/meta/classes/base.bbclass
> > +++ b/meta/classes/base.bbclass
> > @@ -206,7 +206,7 @@ def buildcfg_vars(d):
> >      for var in statusvars:
> >          value = d.getVar(var)
> >          if value is not None:
> > -            yield '%-17s = "%s"' % (var, value)
> > +            yield '%-17s = "%s"' % (var, " ".join(value.split()))
>
> This fix has been rejected once already:
>
>   http://lists.openembedded.org/pipermail/openembedded-core/
> 2016-November/129358.html
>
> The preferred alternative was to remove all duplicated whitespace in
> the BUILDCFG_VARS variables:
>
>   http://git.openembedded.org/openembedded-core/commit/?id=
> 5610c6397ee098dd998b7417b343494de77179f9
>   http://git.openembedded.org/openembedded-core/commit/?id=
> 971e43270173afb08f21ffac16a4157f7e611b81
>
> >  def buildcfg_neededvars(d):
> >      needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170823/34c83ebe/attachment-0002.html>