[OE-core] [PATCH] base.bbclass: ensure HOSTTOOLS links point to executables

Ross Burton ross.burton at intel.com
Thu Mar 30 13:34:10 UTC 2017


Use the new executable argument to bb.utils.which() to ensure that the symlinks
point to executable files and not for example directories with the right name
which happened to be on $PATH.

[ YOCTO #11256 ]

Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/classes/base.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index cf8748a..e29821f 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -128,9 +128,9 @@ def setup_hosttools_dir(dest, toolsvar, d, fatal=True):
     for tool in tools:
         desttool = os.path.join(dest, tool)
         if not os.path.exists(desttool):
-            srctool = bb.utils.which(path, tool)
+            srctool = bb.utils.which(path, tool, executable=True)
             if "ccache" in srctool:
-                srctool = bb.utils.which(path, tool, direction=1)
+                srctool = bb.utils.which(path, tool, executable=True, direction=1)
             if srctool:
                 os.symlink(srctool, desttool)
             else:
-- 
2.8.1




More information about the Openembedded-core mailing list