[OE-core] [PATCH] base.bbclass: ensure HOSTTOOLS links point to executables

[Martin Jansa]

Shouldn't this bump required bitbake version?

On Thu, Mar 30, 2017 at 3:34 PM, Ross Burton <ross.burton at intel.com> wrote:

> Use the new executable argument to bb.utils.which() to ensure that the
> symlinks
> point to executable files and not for example directories with the right
> name
> which happened to be on $PATH.
>
> [ YOCTO #11256 ]
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/classes/base.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index cf8748a..e29821f 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -128,9 +128,9 @@ def setup_hosttools_dir(dest, toolsvar, d, fatal=True):
>      for tool in tools:
>          desttool = os.path.join(dest, tool)
>          if not os.path.exists(desttool):
> -            srctool = bb.utils.which(path, tool)
> +            srctool = bb.utils.which(path, tool, executable=True)
>              if "ccache" in srctool:
> -                srctool = bb.utils.which(path, tool, direction=1)
> +                srctool = bb.utils.which(path, tool, executable=True,
> direction=1)
>              if srctool:
>                  os.symlink(srctool, desttool)
>              else:
> --
> 2.8.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170330/1f05b6d2/attachment-0002.html>