[OE-core] [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue

[Denys Dmytriyenko]

On Mon, May 15, 2017 at 03:09:32AM +0000, C.R. Guo wrote:
> Hello Denys ,
> 
> 
> for example:
> KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb"

^^^^^^^^^^^^^^^^^^^^


> ${DTB}= "freescale/fsl-ls1046a-rdb.dtb"

^^^^^^^^^^^^^^^^^^^^


> DTB=`basename ${DTB}`
> 
> ${DTB}= "fsl-ls1046a-rdb.dtb"
> 
> if use  DTB_PATH="arch/${ARCH}/boot/dts/${DTB}"
> 
> 
> DTB_PATH = ="arch/${ARCH}/boot/dts/fsl-ls1046a-rdb.dtb"
> 
> but  dtb files real path is  arch/${ARCH}/boot/dts/freescale/fsl-ls1046a-rdb.dtb"

The original DTB and KERNEL_DEVICETREE above still have the correct path, 
don't they?

-- 
Denys


> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis at denix.org] 
> Sent: Friday, May 12, 2017 11:12 PM
> To: Chunrong Guo
> Cc: openembedded-core at lists.openembedded.org; C.R. Guo
> Subject: Re: [OE-core] [PATCH 3/3] kernel-fitimage: fix KERNEL_DEVICETREE includes subdirectory issue
> 
> On Wed, May 10, 2017 at 04:47:13PM +0800, Chunrong Guo wrote:
> > From: Chunrong Guo <chunrong.guo at nxp.com>
> > 
> >     * For example:
> >       KERNEL_DEVICETREE ?= "freescale/fsl-ls1046a-rdb.dtb"
> > 
> >       ${DTB}= "freescale/fsl-ls1046a-rdb.dtb"
> > 
> >       but only fsl-ls1046a-rdb.dtb  should be used in fit-image.its
> > 
> > Signed-off-by: Chunrong Guo <B40290 at freescale.com>
> > ---
> >  meta/classes/kernel-fitimage.bbclass | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/kernel-fitimage.bbclass 
> > b/meta/classes/kernel-fitimage.bbclass
> > index 9fa836f..3171d10 100644
> > --- a/meta/classes/kernel-fitimage.bbclass
> > +++ b/meta/classes/kernel-fitimage.bbclass
> > @@ -346,7 +346,10 @@ fitimage_assemble() {
> >  				bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used."
> >  				DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`
> >  			fi
> > -			DTB_PATH="arch/${ARCH}/boot/dts/${DTB}"
> > +                          
> > +			DTB=`basename ${DTB}`
> > +                        DTB_PATH=`find arch/${ARCH}/boot -name 
> > +"${DTB}"`
> 
> Any way to not use "find" here? Shouldn't KERNEL_DEVICETREE and DTB_PATH already give you the full path?
> 
> 
> > + 
> >  			if [ ! -e "${DTB_PATH}" ]; then
> >  				DTB_PATH="arch/${ARCH}/boot/${DTB}"
> >  			fi
> > -- 
> > 1.8.3.2
> > 
> > -- 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>