[OE-core] [PATCH 1/2] wic: When using --use-uuid make sure that we update the fstab with PARTUUID

[Otavio Salvador]

On Mon, Nov 6, 2017 at 10:44 AM, Tom Rini <trini at konsulko.com> wrote:
> On Mon, Nov 06, 2017 at 09:36:20AM -0200, Otavio Salvador wrote:
>> On Mon, Nov 6, 2017 at 8:08 AM, Ed Bartosh <ed.bartosh at linux.intel.com> wrote:
>> > On Fri, Nov 03, 2017 at 08:51:50AM -0400, Tom Rini wrote:
>> >> On Fri, Oct 20, 2017 at 09:15:05AM -0400, Tom Rini wrote:
>> >> > On Tue, Oct 10, 2017 at 05:01:49PM -0400, Tom Rini wrote:
>> >> > > On Thu, Sep 21, 2017 at 01:46:16PM -0400, Tom Rini wrote:
>> >> > > > When we have been told to use the UUID we should also update the fstab
>> >> > > > to make use of PARTUUID instead of hard-coding the device in question.
>> >> > > > This will make the resulting image much more portable.
>> >> > > >
>> >> > > > Signed-off-by: Tom Rini <trini at konsulko.com>
>> >> > > > ---
>> >> > > >  scripts/lib/wic/plugins/imager/direct.py | 9 ++++++---
>> >> > > >  1 file changed, 6 insertions(+), 3 deletions(-)
>> >> > >
>> >> > > Where we did we end up with this?  Ed pointed out that you can tell wic
>> >> > > to use a specific UUID, so reproducible images are not a problem.  And
>> >> > > making images that are readily portable is why other distros use
>> >> > > UUID/LABEL and not device names as much as possible.  I personally enjoy
>> >> > > being able to put an image on uSD for minnow and have it work :)
>> >> > > Thanks!
>> >> >
>> >> > ping?
>> >>
>> >> I was just reminded about the real problems this solves (swap isn't
>> >> /dev/sda3, boot is being excessively slow), so, ping?
>> >>
>> >
>> > I'm generally ok with the patchset. The only thing I'm thinking of is if busybox mount
>> > supports PARTUUID syntax in fstab. Can you check this, please?
>>
>> It does.
>
> It doesn't, you need util-linux for a mount that figures these out (or,
> it did when I wrote the patch set).  That's why 2/2 only updates the
> systemd canned wks as that _will_ have full mount.  But please note that
> you can already make a wks file that doesn't work with busybox mount by
> using the --use-uuid flag for non-root partitions :)

For the root, why you don't use U-Boot to figure the uuid and pass it
as cmdline, in root=? It is just a question as this is how we fixed
this for meta-freescale.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750