[OE-core] Multiconfig builds broken in master

[Alex Kiernan]

Thanks for the reply and the help.

I'm trying and failing to reproduce it separated out into a simple
reproducible example... my supposition is it's something in our custom
distro config that's wrong, which this change shows up, but I've
failed to find it so far. If I comment out enough checks so that it
doesn't fail on checks inside the layers so I can run `bitbake -e`
then I get DISTRO_FEATURES which includes everything I expect.

On Wed, Aug 29, 2018 at 9:02 PM Alejandro Enedino Hernandez Samaniego
<alejandro.enedino.hernandez-samaniego at xilinx.com> wrote:
>
> Hello Alex,
>
> Firs of all, your issue is not a multiconfig problem, and is not caused
> by commit b8730f6 .
>
>
> I was able to reproduce your problem before and after reverting the
> specified commit.
>
>
> As your error log says, ostree is not in the list of valid image
> features, if you add debug flags to bitbake
>
> you can see that the ostree-image.bbclass file is not even being parsed,
> hence why ostree was never added
>
> as a valid image feature.
>
>
> Why was it never parsed?
>
> because theres no INHERITs/inherits pointing to it.
>
> greping though the iot-refkit repo we can see that for example the
> refkit-image (I don't know what your production image is based on I'm
> just assuming) contains the following:
>
> meta-refkit-core/classes/refkit-image.bbclass: inherit
> ${@oe.utils.all_distro_features(d, 'ostree', 'ostree-image')}
>
> So it will only be inherited if the DISTRO_FEATURE ostree is included.
>
> Adding ostree to DISTRO_FEATURES on the <multiconf>.conf, allows the
> build to find the ostree IMAGE_FEATURE correctly.
>
>
> Alejandro
>
>
>
>
> On 08/29/2018 06:39 AM, Alex Kiernan wrote:
> > I've run into a weird multiconfig problem on master which seems to
> > have been introduced with
> >
> > b8730f6 ("bitbake: bitbake: Add support for multiconfig dependencies")
> >
> > Before that, I could happily use:
> >
> > bitbake multiconfig:gplv2:production-image
> >
> > whereas now it fails (gplv2 is a multiconfig which basically just sets
> > TMPDIR and INCOMPATIBLE_LICENSES).
> >
> > The error suggests failure to populate IMAGE_FEATURES correctly:
> >
> > ERROR: Nothing PROVIDES 'production-image'
> > production-image was skipped: 'ostree' in IMAGE_FEATURES is not a
> > valid image feature. Valid features: allow-empty-password
> > allow-root-login autologin dbg-pkgs debug-tweaks dev-pkgs doc doc-pkgs
> > eclipse-debug empty-root-password hwcodecs muted nfs-client nfs-server
> > package-management post-install-logging ptest-pkgs read-only-rootfs
> > splash ssh-server-dropbear ssh-server-openssh staticdev-pkgs
> > tools-debug tools-profile tools-sdk tools-testapps usb-nmc x11
> > x11-base x11-sato
> >
> > (the ostree feature is introduced by a layer derived from the Intel
> > IoT refkit - https://github.com/intel/intel-iot-refkit/blob/master/meta-refkit-core/classes/ostree-image.bbclass)
> >
> > If I revert that single commit everything works again.
> >
> > Clearly there's nothing in that changeset which is touching
> > IMAGE_FEATURES, so it's something way more subtle!
> >
>


--
Alex Kiernan