[OE-core] [PATCH] iputils: add libidn dependency

[Khem Raj]

On Tue, Feb 6, 2018 at 2:44 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> * https://github.com/iputils/iputils/blob/master/RELNOTES.old
>   mentiones that IDN was enabled by default in:
>   [s20160308] and surprisingly the same in [s20150815]
>   but there are no release notes for s20151218 version we were using until
>   now, don't know how it really relates to [s20150815].
>
> * https://github.com/iputils/iputils/commit/f3a461603ef4fb7512ade3bdb73fe1824e294547
>
> * fails with:
>   | In file included from ping_common.c:1:0:
>   | ping.h:39:10: fatal error: idna.h: No such file or directory
>   |  #include <idna.h>
>   |           ^~~~~~~~
>
> * Easiest way to reproduce this failure is to remove libidn from gnutls
>   PACKAGECONFIG or to use gnutls which doesn't have libidn PACKAGECONFIG
>   at all (like the one in meta-gplv2).

I think this should be turned into a PACKAGECONFIG and turned off
by default. It doesnt seem to be working as they have found bug in
libidn which needs to be fixed for it to work here. Prior default was to
disable it so we keep that.

>
> * First it leads to following QA issue:
>   http://errors.yoctoproject.org/Errors/Build/53212/
>   ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-ping rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps]
>   ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-traceroute6 rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps]
>   ERROR: iputils-s20161105-r0 do_package_qa: QA run found fatal errors.
>   Please consider fixing them.
>   ERROR: iputils-s20161105-r0 do_package_qa: Function failed:
>   do_package_qa
>   ERROR: Logfile of failure stored in: /OE/build/oe-core/tmp-glibc/work/core2-64-oe-linux/iputils/s20161105-r0/temp/log.do_package_qa.7627
>   ERROR: Task (/OE/build/oe-core/openembedded-core/meta/recipes-extended/iputils/iputils_s20161105.bb:do_package_qa) failed with exit code '1'
>
> * But if you cleansstate iputils as well (after removing libidn from
>   gnutls PACKAGECONFIG) to empty iputils RSS, then you get the error about
>   missing idna.h:
>   http://errors.yoctoproject.org/Errors/Build/53213/
>
> * Adding the libidn dependency explicitly in iputils recipe fixes the
>   issue.
>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  meta/recipes-extended/iputils/iputils_s20161105.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/iputils/iputils_s20161105.bb b/meta/recipes-extended/iputils/iputils_s20161105.bb
> index ad7dbc4d4a..0acf2be5d3 100644
> --- a/meta/recipes-extended/iputils/iputils_s20161105.bb
> +++ b/meta/recipes-extended/iputils/iputils_s20161105.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://ping.c;beginline=1;endline=35;md5=f9ceb201733e9a6cf8f
>                      file://arping.c;beginline=1;endline=11;md5=fe84301b5c2655c950f8b92a057fafa6 \
>                      file://tftpd.c;beginline=1;endline=32;md5=28834bf8a91a5b8a92755dbee709ef96 "
>
> -DEPENDS = "gnutls libcap libgcrypt"
> +DEPENDS = "gnutls libcap libgcrypt libidn"
>
>  SRC_URI = "git://github.com/iputils/iputils \
>             file://0001-Fix-build-on-MUSL.patch \
> --
> 2.15.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core