[OE-core] [PATCH 12/27] kmod: define bashcompletiondir

[Maxin B. John]

Hi Ross,

On Wed, Feb 21, 2018 at 12:09:36AM +0000, Burton, Ross wrote:

>>On 19 February 2018 at 08:37, Maxin B. John <maxin.john at intel.com> wrote:
>>
>> After moving to pkgconf, kmod package qa test fails without it.
>
>Is this failing because pkgconf returns a full path (/path/to/my/build/usr/share/bash-completion) instead of the path in the pc (/usr/share/bash-completion)?  In the context of a target path in a makefile, the latter is correct and the former is very wrong.

Due to this line in configure.ac:
with_bashcompletiondir=$($PKG_CONFIG --variable=completionsdir bash-completion)

combined with this:
$(INSTALL_DATA) $$files "$(DESTDIR)$(bashcompletiondir)"

>I really do think that the pkgconfig and pkgconf maintainers need to be locked in a room and argue this out.  It's not a drop-in replacement if the behaviour changes...

Good suggestion :) 
While ageeing that these changes doesn't look good, I will try to find other reasonable fixes, if any.

>Ross
Best Regards,
Maxin