[OE-core] [PATCH 12/27] kmod: define bashcompletiondir

[Burton, Ross]

On 21 February 2018 at 09:13, Maxin B. John <maxin.john at intel.com> wrote:

> On Wed, Feb 21, 2018 at 12:09:36AM +0000, Burton, Ross wrote:
>
> >>On 19 February 2018 at 08:37, Maxin B. John <maxin.john at intel.com>
> wrote:
> >>
> >> After moving to pkgconf, kmod package qa test fails without it.
> >
> >Is this failing because pkgconf returns a full path
> (/path/to/my/build/usr/share/bash-completion) instead of the path in the
> pc (/usr/share/bash-completion)?  In the context of a target path in a
> makefile, the latter is correct and the former is very wrong.
>
> Due to this line in configure.ac:
> with_bashcompletiondir=$($PKG_CONFIG --variable=completionsdir
> bash-completion)
>
> combined with this:
> $(INSTALL_DATA) $$files "$(DESTDIR)$(bashcompletiondir)"
>

Which you have to admit seems like the right thing to do...  I'd argue that
pkgconf is doing the wrong thing here.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180221/64462147/attachment-0002.html>