[OE-core] [PATCH] python-setuptools.inc: avoid using += with an over-ride

Andre McCurdy armccurdy at gmail.com
Thu Jul 5 23:39:30 UTC 2018


On Wed, Jul 4, 2018 at 5:53 AM, Burton, Ross <ross.burton at intel.com> wrote:
> On 4 July 2018 at 01:55, Andre McCurdy <armccurdy at gmail.com> wrote:
>>  DEPENDS += "${PYTHON_PN}"
>> -DEPENDS_class-native += "${PYTHON_PN}-native"
>> -DEPENDS_class-nativesdk += "nativesdk-${PYTHON_PN}"
>> +DEPENDS_class-native = "${PYTHON_PN}-native"
>> +DEPENDS_class-nativesdk = "nativesdk-${PYTHON_PN}"
>
> Whilst there's nothing wrong with this patch, as the BBCLASSEXTEND
> handles DEPENDS-munging isn't this a better fix:
>
>   DEPENDS += "${PYTHON_PN}"
>  -DEPENDS_class-native += "${PYTHON_PN}-native"
>  -DEPENDS_class-nativesdk += "nativesdk-${PYTHON_PN}"

Removing the over-rides completely results in both the native and
nativesdk variants gaining a new dependency on
python-distribute-native (courtesy of setuptools.bbclass).



More information about the Openembedded-core mailing list