[OE-core] [PATCH] python-setuptools.inc: avoid using += with an over-ride

[Burton, Ross]

On 6 July 2018 at 00:39, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Wed, Jul 4, 2018 at 5:53 AM, Burton, Ross <ross.burton at intel.com> wrote:
>> On 4 July 2018 at 01:55, Andre McCurdy <armccurdy at gmail.com> wrote:
>>>  DEPENDS += "${PYTHON_PN}"
>>> -DEPENDS_class-native += "${PYTHON_PN}-native"
>>> -DEPENDS_class-nativesdk += "nativesdk-${PYTHON_PN}"
>>> +DEPENDS_class-native = "${PYTHON_PN}-native"
>>> +DEPENDS_class-nativesdk = "nativesdk-${PYTHON_PN}"
>>
>> Whilst there's nothing wrong with this patch, as the BBCLASSEXTEND
>> handles DEPENDS-munging isn't this a better fix:
>>
>>   DEPENDS += "${PYTHON_PN}"
>>  -DEPENDS_class-native += "${PYTHON_PN}-native"
>>  -DEPENDS_class-nativesdk += "nativesdk-${PYTHON_PN}"
>
> Removing the over-rides completely results in both the native and
> nativesdk variants gaining a new dependency on
> python-distribute-native (courtesy of setuptools.bbclass).

setuptools.bbclass:DEPENDS += "python-distribute-native"

If python-distribute-native is a build dependency for target then its
a dependency for native and nativesdk too, right?

Considering python-distribute is just an alias for python-setuptools
(its a RPROVIDES in the recipe, and the pip entry is just a
dependnecy) I guess the setuptools class should follow setuptools3 and
depend on python-setuptools-native instead of
python-distribute-native.

Context is this from 2015:

commit c4553e07cdbec5c29a74a43e0c5fdb2bb5583f7a
Author: Alejandro Hernandez <alejandro.hernandez at linux.intel.com>
Date:   Thu May 14 16:49:56 2015 +0000

    python3-distribute: Upgrade to python3-setuptools 15.2

    python3-distribute was merged back to python3-setuptools in 2013,
    and it is no longer being maintained, this upgrade also provides
    functionality that will be needed for python3-pip.

The same needs to be applied to the py2 classes, as both Py2 and Py3
use the same version of setuptools.

Ross