[OE-core] [PATCH] waf.bbclass: correct the searching patch of waf

[Joshua Watt]

On Thu, May 24, 2018, 22:10 Yue Tao <Yue.Tao at windriver.com> wrote:

> The waf is localed at ${S}/buildtools/bin/, not ${S}. Update the
> subsrcdir to look for the right path. The WARNINGs below can be fixed
> by the fix.
>
> WARNING: lib32-libtalloc-2.1.9-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-libtdb-1.3.14-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-libtevent-0.9.31-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-libldb-1.1.29-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-samba-4.6.7-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
>
> Signed-off-by: Yue Tao <Yue.Tao at windriver.com>
> ---
>  meta/classes/waf.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass
> index 19e93761b3..f8e66835fb 100644
> --- a/meta/classes/waf.bbclass
> +++ b/meta/classes/waf.bbclass
> @@ -7,7 +7,7 @@ python waf_preconfigure() {
>      import subprocess
>      from distutils.version import StrictVersion
>      subsrcdir = d.getVar('S')
> -    wafbin = os.path.join(subsrcdir, 'waf')
> +    wafbin = os.path.join(subsrcdir + '/buildtools/bin/', 'waf')
>

NACK. ${S}/waf is the "standard" location for waf, if your recipe has it in
a different location, you need to parameterize it. Probably something like:

 WAF ?= "${S}/waf"

However, I thought these recipes were inheriting from waf-samba.bbclass
which already does the right thing. Perhaps you have an outdated version of
meta-oe?

     try:
>          result = subprocess.check_output([wafbin, '--version'],
> cwd=subsrcdir, stderr=subprocess.STDOUT)
>          version = result.decode('utf-8').split()[1]
> --
> 2.17.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180524/9d828d06/attachment-0002.html>