[OE-core] [PATCH] waf.bbclass: correct the searching patch of waf
yue.tao
yue.tao at windriver.com
Fri May 25 10:33:59 UTC 2018
You're correct. After updating the last commit of meta-oe, the commit
below has already fixed this issue. Thank Watt.
commit 29e280ee11c9a6f13c004ff25299668e4616f275
Author: Joshua Watt <jpewhacker at gmail.com>
Date: Mon Feb 12 10:20:41 2018 -0600
waf-samba.bbclass: No longer inherit waf.bbclass
waf-samba.bbclass uses waf in a very different way than the "standard"
method that waf.bbclass targets and ends getting very little useful
functionality from that class.
Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
Signed-off-by: Armin Kuster <akuster808 at gmail.com>
Thanks,
yue.tao
On 2018年05月25日 11:46, Joshua Watt wrote:
>
>
> On Thu, May 24, 2018, 22:10 Yue Tao <Yue.Tao at windriver.com
> <mailto:Yue.Tao at windriver.com>> wrote:
>
> The waf is localed at ${S}/buildtools/bin/, not ${S}. Update the
> subsrcdir to look for the right path. The WARNINGs below can be fixed
> by the fix.
>
> WARNING: lib32-libtalloc-2.1.9-r0 do_configure: Unable to execute
> waf --version, exit code 127. Assuming waf version without
> bindir/libdir support.
> WARNING: lib32-libtdb-1.3.14-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-libtevent-0.9.31-r0 do_configure: Unable to execute
> waf --version, exit code 127. Assuming waf version without
> bindir/libdir support.
> WARNING: lib32-libldb-1.1.29-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
> WARNING: lib32-samba-4.6.7-r0 do_configure: Unable to execute waf
> --version, exit code 127. Assuming waf version without bindir/libdir
> support.
>
> Signed-off-by: Yue Tao <Yue.Tao at windriver.com
> <mailto:Yue.Tao at windriver.com>>
> ---
> meta/classes/waf.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass
> index 19e93761b3..f8e66835fb 100644
> --- a/meta/classes/waf.bbclass
> +++ b/meta/classes/waf.bbclass
> @@ -7,7 +7,7 @@ python waf_preconfigure() {
> import subprocess
> from distutils.version import StrictVersion
> subsrcdir = d.getVar('S')
> - wafbin = os.path.join(subsrcdir, 'waf')
> + wafbin = os.path.join(subsrcdir + '/buildtools/bin/', 'waf')
>
>
> NACK. ${S}/waf is the "standard" location for waf, if your recipe has it
> in a different location, you need to parameterize it. Probably something
> like:
>
> WAF ?= "${S}/waf"
>
> However, I thought these recipes were inheriting from waf-samba.bbclass
> which already does the right thing. Perhaps you have an outdated version
> of meta-oe?
>
> try:
> result = subprocess.check_output([wafbin, '--version'],
> cwd=subsrcdir, stderr=subprocess.STDOUT)
> version = result.decode('utf-8').split()[1]
> --
> 2.17.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> <mailto:Openembedded-core at lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
More information about the Openembedded-core
mailing list